mgr: safety checks on pyThreadState usage #18093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcsp
force-pushed
the
wip-mgr-gil-safety
branch
from
c484303
to
8dc93fb
Compare
tchaikov
approved these changes
Oct 16, 2017
| @@ -46,8 +47,8 @@ class MgrPyModule | |||
| private: | |||
| const std::string module_name; | |||
| PyObject *pClassInstance; | |||
| PyThreadState *pMainThreadState; | |||
| PyThreadState *pMyThreadState = nullptr; | |||
| SafeThreadState pMainThreadState; | |||
There was a problem hiding this comment.
nit, they are not pointers anymore. also, i think we might want to stick with the naming convention used by boost, i.e. not_camel_case instead of the camelCase.
There was a problem hiding this comment.
For the moment I would like to keep the name the same to make merging with my other branches easier
tserong
approved these changes
Oct 16, 2017
added 3 commits
October 16, 2017 07:06
Even at 20, it's pretty heavy to be logging every lock acquire/release. Signed-off-by: John Spray <john.spray@redhat.com>
The inclusion of Python.h in the .h was awkward for other files including Gil.h. Signed-off-by: John Spray <john.spray@redhat.com>
Previously relied on the caller of Gil() to pass new_thread=true if they would be calling from a different thread. Enforce this with an assertion, by wrapping PyThreadState in a SafeThreadState class that remembers which POSIX thread it's meant to be used in. Signed-off-by: John Spray <john.spray@redhat.com>
jcsp
force-pushed
the
wip-mgr-gil-safety
branch
from
8dc93fb
to
625e1b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.