msg: reimplement sigpipe blocking #18105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this on my box using the #define swap you see in the last two commits there. |
|
@gregsfortytwo |
|
Looks nice and clean to me! @wjwithagen if you can test that would be very helpful! |
…_NOSIGNAL" This reverts commit 131deb3. It added code that shouldn't have entered the project repo. Conflicts: src/msg/async/AsyncConnection.cc src/msg/async/AsyncConnection.h src/msg/simple/Pipe.cc src/msg/simple/Pipe.h Signed-off-by: Greg Farnum <gfarnum@redhat.com>
This is fairly clean: we define an RAII object in the Messenger.h on Solaris, and "declare" it with a macro in the implementations. There's no code duplication and on Linux it's just entirely compiled out. Signed-off-by: Greg Farnum <gfarnum@redhat.com>
Note that since this sets MSG_NOSIGNAL to 0 it won't take effect on the ::send[msg] invocations Signed-off-by: Greg Farnum <gfarnum@redhat.com>
This reverts commit a76181d. Signed-off-by: Greg Farnum <gfarnum@redhat.com>
gregsfortytwo
force-pushed
the
wip-sigpipe-porting
branch
from
0afc7b4
to
0e15cab
Compare
|
Rebased on latest master because "make check" had a weird white space error in it. |
|
@liewegas @gregsfortytwo |
|
@liewegas @gregsfortytwo Which is probably due to me messing about with tools and other tests: |
|
Excellent. (There's no way an rbd mirroring test would expose problems if nothing else did.) |
|
luminous backport: #18126 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.