os/bluestore: fix another aio stall/deadlock #18118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to wake the kv thread whenever setting deferred_aggressive to ensure that txns with deferred io that have committed but haven't submitted their deferred writes get submitted. This aligns us with the other users of deferred_aggressive (e.g., _osr_drain_all). Signed-off-by: Sage Weil <sage@redhat.com>
I'm not quite sure why the FunctionContext did not ever execute on the finisher thread (perhaps the [&] captured some state on the stack that it shouldn't have?). In any case, using a traditional Context here appears to resolve the problem (of the async deferred_try_submit() never executing, leading to a bluestore stall/deadlock). Fixes: http://tracker.ceph.com/issues/21470 Signed-off-by: Sage Weil <sage@redhat.com>
xiexingguo
approved these changes
Oct 5, 2017
|
backport is #18127 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/21470