Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: Multipart upload may failed when object size is large #18123

Closed

Conversation

mdw-at-linuxbox
Copy link
Contributor

[ revised to use common rgw logic to parse oids. - Marcus Watts <mwatts@redhat.com ]

Fixes:http://tracker.ceph.com/issues/21565

Signed-off-by: Sibei Gao gaosb@inspur.com

[ revised to use common rgw logic to parse oids.  - Marcus Watts <mwatts@redhat.com ]

Fixes:http://tracker.ceph.com/issues/21565

Signed-off-by: Sibei Gao <gaosb@inspur.com>
@mattbenjamin
Copy link
Contributor

@gaosibei , @mdw-at-linuxbox confirms this fix to be important, but I'm a bit confused how it arises, and also about the string parsing as a mechanism; can you provide some detail on how / when this case reproduces, and maybe on the choice of approaches for solving?

@mattbenjamin
Copy link
Contributor

@gaosibei ok, I understand the reproducer from the tracker; I think we need (and @yehudasa agrees we need) a different mechanism to detect such a case

@gaosibei
Copy link

gaosibei commented Oct 6, 2017

@mattbenjamin

Do you need me to provide a new method to fix this bug?

@mattbenjamin
Copy link
Contributor

@gaosibei yes, we'd like a new mechanism--if protocol change is required, we can motivate it in Mimic

@gaosibei
Copy link

gaosibei commented Oct 6, 2017

@mattbenjamin Before geive a new method. I want to konw What conditions need to meet for the new mechanism? And what are the disadvantages of the current method?

@mattbenjamin
Copy link
Contributor

@gaosibei my intuition was, we shouldn't need to parse object names in order to identify the full operation being performed is completing a multipart upload; @mdw-at-linuxbox , @yehudasa , do you want to amplify?

@gaosibei
Copy link

gaosibei commented Oct 6, 2017

@mattbenjamin @mdw-at-linuxbox
Now, I give a new method to fix this bug which don't need parse object names.

The PR is: #17960

@liewegas liewegas changed the title RGW: Multipart upload may failed when object size is large rgw: Multipart upload may failed when object size is large Nov 17, 2017
@liewegas liewegas added the rgw label Nov 17, 2017
@liewegas
Copy link
Member

closing this on preference to #17960

@liewegas liewegas closed this Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants