cleanup: Replacing MIN,MAX with std::min,std::max #18124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitkumar50
force-pushed
the
cleanup-Min-Max
branch
2 times, most recently
from
084644c
to
3d7b401
Compare
|
@liewegas Can you please review? |
|
Looks good, but needs rebase. Also, can you verify it doesn't generate new warnings? |
|
@liewegas Will do that .. |
|
It does not generates new warning, would be resolving merge conflicts |
amitkumar50
force-pushed
the
cleanup-Min-Max
branch
from
3d7b401
to
0748d7c
Compare
|
@liewegas Can you plz review? |
Signed-off-by: Amit Kumar <amitkuma@redhat.com>
|
@liewegas ping |
This was referenced Dec 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amit Kumar amitkuma@redhat.com