Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Replacing MIN,MAX with std::min,std::max #18124

Merged
merged 1 commit into from Dec 1, 2017

Conversation

Projects
None yet
4 participants
@amitkumar50
Copy link
Contributor

commented Oct 5, 2017

Signed-off-by: Amit Kumar amitkuma@redhat.com

@amitkumar50 amitkumar50 force-pushed the amitkumar50:cleanup-Min-Max branch 2 times, most recently from 084644c to 3d7b401 Oct 5, 2017

@cbodley cbodley added the cleanup label Oct 5, 2017

@amitkumar50

This comment has been minimized.

Copy link
Contributor Author

commented Oct 19, 2017

@liewegas Can you please review?

@liewegas

This comment has been minimized.

Copy link
Member

commented Oct 19, 2017

Looks good, but needs rebase. Also, can you verify it doesn't generate new warnings?

@amitkumar50

This comment has been minimized.

Copy link
Contributor Author

commented Oct 28, 2017

@liewegas Will do that ..

@amitkumar50

This comment has been minimized.

Copy link
Contributor Author

commented Nov 7, 2017

It does not generates new warning, would be resolving merge conflicts

@amitkumar50 amitkumar50 force-pushed the amitkumar50:cleanup-Min-Max branch from 3d7b401 to 0748d7c Nov 20, 2017

@amitkumar50

This comment has been minimized.

Copy link
Contributor Author

commented Nov 20, 2017

@liewegas Can you plz review?

cleanup: Replacing MIN,MAX with std::min,std::max
Signed-off-by: Amit Kumar <amitkuma@redhat.com>
@amitkumar50

This comment has been minimized.

Copy link
Contributor Author

commented Nov 28, 2017

@liewegas ping

@liewegas
Copy link
Member

left a comment

yay!

@tchaikov tchaikov merged commit 4e5e566 into ceph:master Dec 1, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.