librbd: fix coverity warning for uninitialized member #18129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillaman
suggested changes
Oct 5, 2017
dillaman
changed the title
dragonylffly
force-pushed
the
wip-fix-coverity-warning-for-uninialized-member
branch
from
0087ce9
to
b09ba9a
Compare
|
@dillaman updated |
dillaman
reviewed
Oct 6, 2017
| @@ -33,7 +33,7 @@ SnapshotProtectRequest<I>::SnapshotProtectRequest(I &image_ctx, | |||
| Context *on_finish, | |||
| const cls::rbd::SnapshotNamespace &snap_namespace, | |||
| const std::string &snap_name) | |||
| : Request<I>(image_ctx, on_finish), m_snap_namespace(snap_namespace), m_snap_name(snap_name) { | |||
| : Request<I>(image_ctx, on_finish), m_snap_namespace(snap_namespace), m_snap_name(snap_name), m_state(STATE_PROTECT_SNAP) { | |||
There was a problem hiding this comment.
Nit: wrap it down to the next line (with proper indentation) before it exceeds 80 characters
| @@ -102,7 +102,7 @@ class MetadataCopyRequest<librbd::MockTestImageCtx> { | |||
| return s_instance; | |||
| } | |||
|
|
|||
| MetadataCopyRequest() { | |||
| MetadataCopyRequest() : on_finish(nullptr) { | |||
There was a problem hiding this comment.
Nit: default initialize to nullptr inline where the variable is defined.
Silence Coverity 1413777 Signed-off-by: Li Wang <laurence.liwang@gmail.com>
Silence coverity 1413790 Signed-off-by: Li Wang <laurence.liwang@gmail.com>
Silence coverity 1396229 Signed-off-by: Li Wang <laurence.liwang@gmail.com>
Silence coverity 1413793 Signed-off-by: Li Wang <laurence.liwang@gmail.com>
Silence coverity 1418957 Signed-off-by: Li Wang <laurence.liwang@gmail.com>
dragonylffly
force-pushed
the
wip-fix-coverity-warning-for-uninialized-member
branch
from
b09ba9a
to
2a8e8c5
Compare
|
@dillaman updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.