rbd-mirror: primary image should register in remote, non-primary image's journal #18136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillaman
changed the title
dillaman
changed the title
|
@ceph-jenkins retest this please |
trociny
reviewed
Oct 8, 2017
| } else if (m_local_image_tag_owner == librbd::Journal<>::LOCAL_MIRROR_UUID) { | ||
| dout(5) << "local image is primary" << dendl; | ||
| on_start_fail(0, "local image is primary"); | ||
| return; |
There was a problem hiding this comment.
@dillaman Running stress test locally I observed a false failure, when an ImageReplayer failed on start with the status "state=up+error, description=remote image does not exist", while it was expected to be "state=up+stopped, description=local image is primary".
The sequence was following:
- a mirrored image (primary) is created in cluster2;
- the local pool watcher for cluster2 mirror daemon gets notification about the new image
- cluster2 mirror daemon starts the image replayer
- start fails in prepare_remote_image because the image does not exist in the remote cluster yet.
If my explanation is not clear or you would like to see details I can provide logs.
There was a problem hiding this comment.
@trociny Thanks -- good catch. Update pushed to ignore the errors from prepare remote if the local image is primary.
added 2 commits
October 9, 2017 20:53
Fixes: http://tracker.ceph.com/issues/21561 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
The client will now be registered before the bootstrap state machine is invoked. Fixes: http://tracker.ceph.com/issues/21561 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.