Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rbd-mirror: primary image should register in remote, non-primary image's journal #18136

Merged
merged 2 commits into from Oct 10, 2017

Conversation

Projects
None yet
2 participants
@dillaman
Copy link
Contributor

commented Oct 5, 2017

No description provided.

@dillaman dillaman changed the title rbd-mirror: primary image should register in remote, non-primary image's journal [DNM] rbd-mirror: primary image should register in remote, non-primary image's journal Oct 5, 2017

@dillaman dillaman force-pushed the dillaman:wip-21561 branch from c000428 to 3a436cb Oct 6, 2017

@dillaman dillaman changed the title [DNM] rbd-mirror: primary image should register in remote, non-primary image's journal rbd-mirror: primary image should register in remote, non-primary image's journal Oct 6, 2017

@trociny

trociny approved these changes Oct 8, 2017

Copy link
Contributor

left a comment

lgtm

@trociny

This comment has been minimized.

Copy link
Contributor

commented Oct 8, 2017

@ceph-jenkins retest this please

} else if (m_local_image_tag_owner == librbd::Journal<>::LOCAL_MIRROR_UUID) {
dout(5) << "local image is primary" << dendl;
on_start_fail(0, "local image is primary");
return;

This comment has been minimized.

Copy link
@trociny

trociny Oct 8, 2017

Contributor

@dillaman Running stress test locally I observed a false failure, when an ImageReplayer failed on start with the status "state=up+error, description=remote image does not exist", while it was expected to be "state=up+stopped, description=local image is primary".

The sequence was following:

  1. a mirrored image (primary) is created in cluster2;
  2. the local pool watcher for cluster2 mirror daemon gets notification about the new image
  3. cluster2 mirror daemon starts the image replayer
  4. start fails in prepare_remote_image because the image does not exist in the remote cluster yet.

If my explanation is not clear or you would like to see details I can provide logs.

This comment has been minimized.

Copy link
@dillaman

dillaman Oct 10, 2017

Author Contributor

@trociny Thanks -- good catch. Update pushed to ignore the errors from prepare remote if the local image is primary.

dillaman added some commits Oct 5, 2017

rbd-mirror: removed duplicate client registration logic
The client will now be registered before the bootstrap state machine
is invoked.

Fixes: http://tracker.ceph.com/issues/21561
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

@dillaman dillaman force-pushed the dillaman:wip-21561 branch from 3a436cb to d774d47 Oct 10, 2017

@trociny trociny merged commit 069c8dc into ceph:master Oct 10, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@dillaman dillaman deleted the dillaman:wip-21561 branch Oct 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.