doc raise exceptions with a base class #18152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although valid in very old Python, it is no longer possible to raise "bare" exceptions without a class. Signed-off-by: Alfredo Deza <adeza@redhat.com>
theanalyst
approved these changes
Oct 6, 2017
|
now the exception is raised properly and the program fails gracefully, but we need to find out what caused that.. |
|
seems to have been introduced in #18070, not sure whether the state diagrams need to be a part of docs build, are these a part of hte doc output? |
tchaikov
approved these changes
Oct 6, 2017
theanalyst
reviewed
Oct 6, 2017
| @@ -107,7 +107,7 @@ def get_state(self, line): | |||
| r"boost::statechart::state_machine<\s*(\w*),\s*(\w*)\s*>", | |||
There was a problem hiding this comment.
changing L93 to match = re.search(r"(\w+::)*::(?P<tag>\w+)::\w+\(\s*const (?P<event>\w+)", makes the script pass locally for me
So that signatures can get parsed when they are split like: PG::RecoveryState::RepWaitBackfillReserved::react( const RemoteReservationCanceled &evt) Signed-off-by: Alfredo Deza <adeza@redhat.com>
alfredodeza
force-pushed
the
wip-fix-doc-exceptions
branch
from
e5595f7
to
9e2a52c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although valid in very old Python, it is no longer possible to raise
"bare" exceptions without a class.
Fixes the following build errors: