Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os: fix 0-length zero semantics, add tests #18159

Merged
merged 3 commits into from Oct 9, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Copy link
Member

commented Oct 6, 2017

@liewegas liewegas added the core label Oct 6, 2017

@liewegas liewegas requested a review from tchaikov Oct 6, 2017

t.create_collection(cid, 0);
t.touch(cid, hoid);
r = apply_transaction(store, &osr, std::move(t));
ASSERT_EQ(r, 0);

This comment has been minimized.

Copy link
@tchaikov

tchaikov Oct 7, 2017

Contributor

the lhs is the expected value, and the rhs is the actual value.

@tchaikov
Copy link
Contributor

left a comment

aside from the nits regarding to expected versus actual, lgtm.

liewegas added some commits Oct 6, 2017

os/ObjectStore: 0-length zero does not change length of object
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas force-pushed the liewegas:wip-21712-b branch from cb21c84 to b588eaf Oct 9, 2017

@liewegas liewegas merged commit 2dbbb35 into ceph:master Oct 9, 2017

0 of 5 checks passed

Docs: build check Docs: building
Details
Signed-off-by checking if commits are signed
Details
Unmodified Submodules checking if PR has modified submodules
Details
make check running make check
Details
make check (arm64) running make check
Details

@liewegas liewegas deleted the liewegas:wip-21712-b branch Oct 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.