Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fix command argument error for radosgw-admin #18175

Merged
merged 1 commit into from Oct 11, 2017

Conversation

Projects
None yet
4 participants
@yaozongyou
Copy link
Contributor

commented Oct 9, 2017

Signed-off-by: Yao Zongyou yaozongyou@vip.qq.com

@yaozongyou

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

The radosgw-admin --help displays reshard process, not reshard execute.
The command help doesn't match with the real command argument.

@yaozongyou yaozongyou changed the title radosgw-admin: fix command arg error. radosgw-admin: fix command argument error. Oct 9, 2017

@joscollin
Copy link
Member

left a comment

Looks good to me.

@joscollin joscollin changed the title radosgw-admin: fix command argument error. rgw: fix command argument error for radosgw-admin Oct 9, 2017

@joscollin

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

@yaozongyou See: http://tracker.ceph.com/issues/21617.

You might want to create a tracker for backporting this fix too.

@yaozongyou

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

@joscollin

This comment has been minimized.

Copy link
Member

commented Oct 9, 2017

@yaozongyou Update it in the Commit message.

rgw: fix command argument error for radosgw-admin.
Fixes: http://tracker.ceph.com/issues/21723
Signed-off-by: Yao Zongyou <yaozongyou@vip.qq.com>

@yaozongyou yaozongyou force-pushed the yaozongyou:fix-radosgw-admin-command-arg-bug branch from 9e86ebb to bba3a89 Oct 9, 2017

@yaozongyou

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

Okay, the Commit message has been updated.

@oritwas

oritwas approved these changes Oct 9, 2017

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Oct 9, 2017

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Oct 10, 2017

@yuriw yuriw merged commit 8ef4760 into ceph:master Oct 11, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@yaozongyou yaozongyou deleted the yaozongyou:fix-radosgw-admin-command-arg-bug branch Oct 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.