Commits on Oct 10, 2017

1. log: fix build on osx …

   we can not assume that the the `rep` type is identical to `time_t` and
   `susecond_t`, on osx they are `int`, not `int64_t`. so cast they as
   necessary.
   
   this fixes the error and warning of
   
   LogClock.h:112:7: error: non-constant-expression cannot be narrowed from type 'rep' (aka 'long long') to '__darwin_suseconds_t' (aka 'int') in initializer list [-Wc++11-narrowing]
                std::chrono::duration_cast<std::chrono::microseconds>(
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   /Users/kefu/dev/ceph/src/log/LogClock.h:112:7: note: insert an explicit cast to silence this issue
                std::chrono::duration_cast<std::chrono::microseconds>(
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   LogClock.h:139:46: warning: format specifies type 'long' but the argument has type 'int' [-Wformat]
                         bdt.tm_hour, bdt.tm_min, bdt.tm_sec, tv.tv_usec / 1000);
                                                              ^~~~~~~~~~~~~~~~~
   
   Signed-off-by: Kefu Chai <kchai@redhat.com>

   

   tchaikov committed Oct 10, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for f29d304
   • Browse repository at this point

   Copy the full SHA

   f29d304 View commit details

   Browse the repository at this point in the history