mon/PGMap: let pg_string_state() return boost::optional<> #18218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kefu Chai <kchai@redhat.com>
better to be specific, so we don't run into the same problem even we are using the MSB of uint64_t for a pg state bit in future. we could, however use uint64_t(-1) to indicate the pg_string_state()'s failure to parse the state string, because pg_string_state() only translate a single state a time. but it's always better to be explicit than implicit. Fixes: http://tracker.ceph.com/issues/21609 Signed-off-by: Kefu Chai <kchai@redhat.com>
Yan-waller
approved these changes
Oct 10, 2017
|
@tchaikov thanks for catching this. |
liewegas
approved these changes
Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a follow-up of #18058, which is halfway to uint64_t pg state.