Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
os/bluestore: dynamic CF configuration; put pglog omap in separate CF #18224
I only scanned this briefly so please feel free to disregard if I'm smoking crack. This feels a bit off to me. I don't like leaking the RocksDB column family implementation details out into bluestore via the KeyValueDB interface unless we have a really good reason (Maybe we do!). I guess I'd favor keeping this out of bluestore and simply having configurables at the rocksdb KeyvalueDB level to put different prefixes in different column families (or even shard the DB or whatever). Personally I would want the KeyValueDB to look like as much of a black box as possible (that ultimately we still control, but bluestore knows nothing about other than the simplest API necessary for storing keys/values).
OTOH, if there are good reasons for doing it this way, I'm cool with it.