Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common/options: enable multiple rocksdb compaction threads for filestore #18232

Merged
merged 1 commit into from
Oct 19, 2017
Merged

common/options: enable multiple rocksdb compaction threads for filestore #18232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/common/options.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3673,7 +3673,7 @@ std::vector<Option> get_global_options() {
// filestore

Option("filestore_rocksdb_options", Option::TYPE_STR, Option::LEVEL_DEV)
.set_default("compaction_readahead_size=2097152")
.set_default("max_background_compactions=8;compaction_readahead_size=2097152")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, can we use , as the separator? to be consistent with other _rocksdb_options.

Copy link
Contributor

@tchaikov tchaikov Oct 11, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

even though, "max_background_compactions" is still supported, but since rocksdb 5.6.0, max_background_compactions is replaced with max_background_jobs. to have 8 background compactions, we can specify "max_background_jobs=10", in which, 2 jobs will be allocated for "max_background_flushes".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, it's more backport-friendly. we can update it in master after it gets merged.

.set_description(""),

Option("filestore_omap_backend", Option::TYPE_STR, Option::LEVEL_DEV)
Expand Down