Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/unittest_bufferlist: check retvals of syscalls #18238

Merged
merged 1 commit into from Oct 16, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Copy link
Contributor

commented Oct 11, 2017

so we can have better understanding of failures like

[ RUN ] BufferList.write_fd_offset
/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/test/bufferlist.cc:2609:
Failure
Expected: 1024 * 2 + offset
Which is: 2248
To be equal to: (unsigned)st.st_size
Which is: 0
[ FAILED ] BufferList.write_fd_offset (4 ms)

Signed-off-by: Kefu Chai kchai@redhat.com

test/unittest_bufferlist: check retvals of syscalls
so we can have better understanding of failures like

[ RUN      ] BufferList.write_fd_offset
/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/test/bufferlist.cc:2609:
Failure
      Expected: 1024 * 2 + offset
      Which is: 2248
To be equal to: (unsigned)st.st_size
      Which is: 0
[  FAILED  ] BufferList.write_fd_offset (4 ms)

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov added the tests label Oct 11, 2017

@tchaikov tchaikov requested a review from jdurgin Oct 11, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2017

[ RUN      ] BufferList.write_fd_offset
/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/test/bufferlist.cc:2609: Failure
      Expected: 1024 * 2 + offset
      Which is: 2248
To be equal to: (unsigned)st.st_size
      Which is: 0
[  FAILED  ] BufferList.write_fd_offset (4 ms)

see also https://jenkins.ceph.com/job/ceph-pull-requests-arm64/7264/consoleFull#20128553736733401c-e9d0-4737-9832-6594c5da0afa, which is a jenkins "make check" failure at #18233

@tchaikov

This comment has been minimized.

Copy link
Contributor Author

commented Oct 13, 2017

@jdurgin ping?

@jdurgin jdurgin merged commit 804f07f into ceph:master Oct 16, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-bufferlist-test branch Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.