os/bluestore/BlueFS: sanity check that alloc->allocate() won't return 0 #18259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If alloc[id]->allocate() returns 0, no space is actually reclaimed. But BlueStore treats returning 0 as success and will keep reclaiming space from BlueFS until hit the given threshold, which turns out to be deadloop-prone. For now, Bitmap and Stupid never return 0-length allocated space (which is instead converted to -ENOSPC to suggest an error to caller), so sanity checking against result code 0 will suffice. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
|
retest this please |
liewegas
approved these changes
Oct 12, 2017
|
@tchaikov Thanks for testing. Kefu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If alloc[id]->allocate() returns 0, no space is actually reclaimed.
But BlueStore treats returning 0 as success and will keep reclaiming
space from BlueFS until hit the given threshold, which turns out to
be deadloop-prone.
For now, Bitmap and Stupid never return 0-length allocated space
(which is instead converted to -ENOSPC to suggest an error to caller),
so sanity checking against result code 0 will suffice.
Signed-off-by: xie xingguo xie.xingguo@zte.com.cn