mon,osd,osdc: refactor snap trimming (phase 1) #18276
changed the title
mon,osd,osdc: reimplement handling of removed_snaps (phase 1)
Oct 30, 2017
3 times, most recently
Nov 3, 2017
5 times, most recently
Nov 8, 2017
referenced this pull request
Nov 17, 2017
gregsfortytwo left a comment
The overall structure here looks good, but there are some issues.
And the missing data on the wire (and other broken checks) make clear that the current QA suite is not sufficient to validate this PR, so it needs some good tests added.
Okay, I think this is ready now.
I took the "easy" path on the purged_snaps updates. The scenario is:
Basically, there are a few options:
I went for 1 instead of 3 because even if we did 3, I'm not sure we can reenable the debug assertion without also carefully ordering our purged_snaps reporting to the mgr to after we have safely persisted the purged_snaps updates on disk. It feels like a lot of work and complexity for very little benefit (a debug assertion).