cmake: bump up required cmake version to 2.8.12 #18285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as both trusty and centos 7.3 offer 2.8.12 Signed-off-by: Kefu Chai <kchai@redhat.com>
we use the global setting of CMAKE_POSITION_INDEPENDENT_CODE for defining this flag. Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
as 2.8.12 is required not, no need to be compatible with 2.8.11 anymore. this reverts 457f023. Signed-off-by: Kefu Chai <kchai@redhat.com>
instead of using "-fvisibility=hidden -fvisibility-inlines-hidden", more cmake-ish this way. Signed-off-by: Kefu Chai <kchai@redhat.com>
there is chance that its "patch" version is empty. in that case, do not include it in its version string. otherwise, we will have something like: Found gperftools: GPERFTOOLS_TCMALLOC_LIBRARY;GPERFTOOLS_TCMALLOC_MINIMAL_LIBRARY;GPERFTOOLS_PROFILER_LIBRARY (found version "2.4.#define TC_VERSION_PATCH """) when running cmake Signed-off-by: Kefu Chai <kchai@redhat.com>
|
retest this please. |
|
@tchaikov lgtm, do I need to worry about the |
|
thanks for your review @alimaredia ! i don't think it's relevant. let me try the spell: retest this please. |
|
fwiw, #18283 has the same failure of test_objectstore_memstore.sh |
cbodley
approved these changes
Oct 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.