Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common/buffer: cleanups #18312

Merged
merged 1 commit into from Oct 17, 2017
Merged

common/buffer: cleanups #18312

merged 1 commit into from Oct 17, 2017

Conversation

shinobu-x
Copy link
Contributor

Signed-off-by: Shinobu Kinjo shinobu@redhat.com

@shinobu-x
common | cleanup: buffer.cc
89a9174 
Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>
@tchaikov tchaikov changed the title common | cleanup: buffer.cc common/buffer: cleanups Oct 16, 2017
@tchaikov
Copy link
Contributor

@shinobu-x
could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes

normally we don't use the notation of "$subcomponent | cleanup" as the prefix.

@tchaikov
Copy link
Contributor

@tchaikov tchaikov merged commit f990847 into ceph:master Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liewegas liewegas liewegas approved these changes

Assignees
No one assigned
Labels
cleanup common needs-qa wip-kefu-testing
Projects
None yet
Milestone
No milestone
3 participants
@shinobu-x @tchaikov @liewegas