Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osd: Don't include same header twice #18319

Merged
merged 1 commit into from Oct 17, 2017
Merged

osd: Don't include same header twice #18319

merged 1 commit into from Oct 17, 2017

Conversation

shinobu-x
Copy link
Contributor

Signed-off-by: Shinobu Kinjo shinobu@redhat.com

@shinobu-x
osd | cleanup: Don't include same header twice
75b812b 
Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>
@joscollin joscollin removed the request for review from wjwithagen October 16, 2017 05:16
@wjwithagen wjwithagen self-requested a review October 16, 2017 08:34
wjwithagen
wjwithagen approved these changes Oct 16, 2017
View reviewed changes
Copy link
Contributor

@wjwithagen wjwithagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiles/binds on FreeBSD

@joscollin
Copy link
Member

@wjwithagen Later on I found that this was just a repetition. Anyway, thanks for the checking on FreeBSD.

@wjwithagen
Copy link
Contributor

@joscollin
Not sure what you mean, there is on one reference to this include.

The includes however here are massive, and not quite in the order I would expect:
system first, globals and commons, only then the file/module specific stuff.

And there is a possible danger lurking by not including compat.h before boost includes.
In this case it probably does not mater because E_NODATA/E_NOATTR is not used in this file, but otherwise FreeBSD is going to use the wrong value for E_NODATA.

@joscollin joscollin changed the title osd | cleanup: Don't include same header twice osd: Don't include same header twice Oct 16, 2017
@tchaikov
Copy link
Contributor

@tchaikov tchaikov merged commit c9414de into ceph:master Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwithagen wjwithagen wjwithagen approved these changes

@joscollin joscollin joscollin approved these changes

Assignees
No one assigned
Labels
cleanup core needs-qa wip-kefu-testing
Projects
None yet
Milestone
No milestone
4 participants
@shinobu-x @joscollin @wjwithagen @tchaikov