librbd: cannot copy all image-metas if we have more than 64 key/value pairs #18328
Conversation
PCzhangPC
force-pushed
the
cplostmeta
branch
2 times, most recently
from
30c1b98
to
f762627
Compare
|
@ceph-jenkins retest this please |
|
@dillaman what about this fix for the copy command? |
dillaman
changed the title
|
@PCzhangPC can you open a tracker ticket for this issue as well? |
PCzhangPC
force-pushed
the
cplostmeta
branch
3 times, most recently
from
49c4c97
to
1b126b8
Compare
|
@dillaman updated |
src/librbd/librbd.cc
Outdated
| @@ -3906,14 +3906,40 @@ extern "C" int rbd_metadata_list(rbd_image_t image, const char *start, uint64_t | |||
| librbd::ImageCtx *ictx = (librbd::ImageCtx *)image; | |||
| tracepoint(librbd, metadata_list_enter, ictx); | |||
| map<string, bufferlist> pairs; | |||
| int r = librbd::metadata_list(ictx, start, max, &pairs); | |||
There was a problem hiding this comment.
What are you fixing here (since the C++ API wasn't updated)?
src/test/librbd/test_librbd.cc
Outdated
| std::string value; | ||
|
|
||
| while (more_results) { | ||
| ASSERT_EQ(0, image2.metadata_list(last_key, 0, &pairs)); |
There was a problem hiding this comment.
You should be able to list all 70 keys in this test in one invocation (and below)
There was a problem hiding this comment.
Can we? we are iterating over metadata items when listing. just like
https://github.com/ceph/ceph/blob/master/src/tools/rbd/action/ImageMeta.cc#L48
There was a problem hiding this comment.
Indeed -- there is no max restriction on the metadata_list librbd API methods. If such a restriction were added, it could be added to librbd::metadata_list in internal.cc so that (1) the OSDs cannot be overloaded,(2) the C and C++ APIs are consistent, and (3) the API-based iteration would only need to be implemented once behind the scene.
There was a problem hiding this comment.
that's fine. so what about i fix the 'metadata lost' bug in 'internal.cc' to get all metadatas and remove iterations in 'ImageMeta.cc' , 'export.cc' and so on in another pr? If so, image.metadata_list() could get all all key/value pairs at one time and there's no need to use iterations in the test of this pr
There was a problem hiding this comment.
oh, i misunderstood what you mean. will update soon
Signed-off-by: PCzhangPC <pengcheng.zhang@easystack.cn>
PCzhangPC
force-pushed
the
cplostmeta
branch
2 times, most recently
from
6d36921
to
be5ad87
Compare
Signed-off-by: PCzhangPC <pengcheng.zhang@easystack.cn>
|
@dillaman updated |
Signed-off-by: PCzhangPC pengcheng.zhang@easystack.cn