RGW: change function parameters from value to refrence #18355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaosibei
force-pushed
the
wip-rgw-refrence
branch
2 times, most recently
from
c90633f
to
58d9c76
Compare
cbodley
reviewed
Oct 17, 2017
src/rgw/rgw_acl_s3.h
Outdated
| @@ -86,7 +86,7 @@ class RGWAccessControlPolicy_S3 : public RGWAccessControlPolicy, public XMLObj | |||
| int rebuild(RGWRados *store, ACLOwner *owner, RGWAccessControlPolicy& dest); | |||
| bool compare_group_name(string& id, ACLGroupTypeEnum group) override; | |||
|
|
|||
| virtual int create_canned(ACLOwner& _owner, ACLOwner& bucket_owner, string canned_acl) { | |||
| virtual int create_canned(ACLOwner& _owner, ACLOwner& bucket_owner, string& canned_acl) { | |||
rzarzynski
requested changes
Oct 17, 2017
src/rgw/rgw_auth.h
Outdated
| @@ -455,7 +455,7 @@ class LocalApplier : public IdentityApplier { | |||
|
|
|||
| LocalApplier(CephContext* const cct, | |||
| const RGWUserInfo& user_info, | |||
| std::string subuser) | |||
| const std::string& subuser) | |||
There was a problem hiding this comment.
I'm afraid that taking subuser by const & here isn't the best option. It would make moving internal data of the incoming std::string to the subuser member impossible. Please consider a scenario when someone instantiate LocalApplier with a temporal variable as the subuser. It can perfectly bind const & but std::move will result in const && in such case, I guess.
gaosibei
force-pushed
the
wip-rgw-refrence
branch
2 times, most recently
from
935bf54
to
c677fbc
Compare
Signed-off-by: Sibei Gao <gaosb@inspur.com>
|
@rzarzynski @cbodley |
rzarzynski
approved these changes
Oct 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use refrence instead of value
Signed-off-by: Sibei Gao gaosb@inspur.com