New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgw: source data in 'default.rgw.buckets.data' may not be deleted after inter-bucket copy #18369
Conversation
cac3d81
to
0a45ebf
Compare
make check succeeded |
@ceph-jenkins make check succeeded or not ? |
upload obj to bucket1 s3cmd put obj s3://bucket1 cp obj from bucket1 to bucket2 s3cmd cp s3://bucket1/obj s3://bucket2 del obj from bucket1 and bucket2 s3cmd del s3://bucket1/obj s3cmd del s3://bucket2/obj you can see the pool 'default.rgw.buckets.data', the data of obj can not deleted. ceph df | grep default.rgw.buckets.data Fixes: http://tracker.ceph.com/issues/21819 Signed-off-by: Xueyu Bai baixueyu@inspur.com
0a45ebf
to
2e11545
Compare
@mkogan1 can you help me to review this PR? |
@mattbenjamin , can you help me to review this PR? |
I am looking into the root cause of this issue. |
@yuriw per discussion in Monday's RGW standup, we're considering taking this change as a hotfix, while we work on a more complete fix; is it possible for this to be added to one of your testing branches? tx, Matt |
http://pulpito.ceph.com/mbenjamin-2017-10-24_15:47:16-rgw-wip-baixueyu-refcount_bug---basic-smithi/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, yehudasa as short-term fix
You can find the problem do like this:
s3cmd put obj s3://bucket1
s3cmd cp s3://bucket1/obj s3://bucket2
s3cmd del s3://bucket1/obj
s3cmd del s3://bucket2/obj
radosgw-admin --name client.radosgw.gateway gc list --include-all
ceph df | grep default.rgw.buckets.data
Fixes: http://tracker.ceph.com/issues/21819
Signed-off-by: Xueyu Bai baixueyu@inspur.com