Revert "radosgw: fix awsv4 header line sort order." #18381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c11485e. The original sort order was compliant with amazon. Failures observed in s3tests turned out to be a bug in boto2 - boto3 and other s3 clients produce the correct sort order. Fixes: http://tracker.ceph.com/issues/21832 Signed-off-by: Casey Bodley <cbodley@redhat.com>
|
jenkins retest this please |
|
thanks @mattbenjamin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c11485e.
The original sort order was compliant with amazon. Failures observed
in s3tests turned out to be a bug in boto2 - boto3 and other s3 clients
produce the correct sort order.
Fixes: http://tracker.ceph.com/issues/21832