Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osd/osd_types.cc: copy extents map too while making clone #18396

Merged
merged 1 commit into from Oct 20, 2017
Merged

osd/osd_types.cc: copy extents map too while making clone #18396

merged 1 commit into from Oct 20, 2017

Conversation

xiexingguo
Copy link
Member

Otherwise we'll lost tracking of logical space usage
if we successfully rollback to clones later.

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

@xiexingguo
osd/osd_types.cc: copy extents map too while making clone
d2d7766 
Otherwise we'll lost tracking of logical space usage
if we successfully rollback to clones later.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@xiexingguo
Copy link
Member Author

xiexingguo commented Oct 19, 2017 •
edited

Hope this can address http://tracker.ceph.com/issues/21750 but I am not sure since I can not stably reproduce it...

I've rerun the failed QA test cases (and several complete rounds of QA) for quite a few times:
http://pulpito.ceph.com/xxg-2017-10-19_04:43:20-rados-wip-scrub-mismatch-distro-basic-smithi/
http://pulpito.ceph.com/xxg-2017-10-19_03:46:48-rados-wip-scrub-mismatch-distro-basic-smithi/
http://pulpito.ceph.com/xxg-2017-10-19_03:46:13-rados-wip-scrub-mismatch-distro-basic-smithi/
http://pulpito.ceph.com/xxg-2017-10-18_11:53:27-rados-wip-scrub-mismatch-distro-basic-smithi/
http://pulpito.ceph.com/xxg-2017-10-18_10:25:25-rados-wip-scrub-mismatch-distro-basic-smithi/

For now the test results are fine.

Anyway, the patch itself does fix something and is ready to merge!

@liewegas
Copy link
Member

Awesome.. this sounds like it's 21750 to me. All of the failures were workloads that were doing snap rollback.

@yuriw
Copy link
Contributor

yuriw commented Oct 19, 2017

wip-yuri3-testing-2017-10-19-1558

@yuriw yuriw merged commit 5f763bf into ceph:master Oct 20, 2017
@xiexingguo xiexingguo deleted the wip-scrub-mismatch branch February 1, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liewegas liewegas liewegas approved these changes

Assignees
No one assigned
Labels
bug-fix core needs-qa wip-yuri3-testing
Projects
None yet
Milestone
No milestone
3 participants
@xiexingguo @liewegas @yuriw