librbd: default to sparse-reads for any IO operation over 64K #18405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillaman
changed the title
trociny
reviewed
Oct 20, 2017
src/librbd/internal.cc
Outdated
|
|
||
| ictx->perfcounter->inc(l_librbd_flush); | ||
| return r; | ||
| return 0; |
There was a problem hiding this comment.
@dillaman Was it your intention to make these flush changes be a part of this commit?
There was a problem hiding this comment.
Negative -- looks like I accidentally checked in my local tweaks to for fio from my benchmarking.
added 2 commits
October 22, 2017 20:57
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Testing BlueStore against both HDDs and OSDs with fully allocated and sparse-allocated objects shows a performance improvement with sparse-read between 32K and 64K. Fixes: http://tracker.ceph.com/issues/21849 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.