New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luminous: librbd: object map batch update might cause OSD suicide timeout #18416

Merged
merged 7 commits into from Oct 27, 2017

Conversation

Projects
None yet
3 participants
@kmroz

kmroz commented Oct 20, 2017

dillaman added some commits Oct 13, 2017

common/buffer: expose hidden const deference operator
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit f35947e)
common/bit_vector: provide constant time iteration of underlying buff…
…erlist

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit daa29f7)
cls/rbd: object map update now utilizes constant-time bit vector oper…
…ations

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit fc99603)
librbd: combine trim state machine object map batch update states
The PRE/POST states were previously divided into two halves for handling
the copy-up batch and the direct removal batch. This can be simplified by
just using a single PRE/POST for the entire deletion region.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 72ce457)

Conflicts:
	src/librbd/operation/TrimRequest.h
librbd: tweaks to support testing of trim state machine
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 3220480)
test/librbd: initial test cases for trim state machine
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 4674b57)
librbd: batch large object map updates into multiple chunks
Fixes: http://tracker.ceph.com/issues/21797
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit 04c5d12)

@kmroz kmroz added this to the luminous milestone Oct 20, 2017

@kmroz kmroz requested a review from dillaman Oct 20, 2017

@dillaman

This comment has been minimized.

Show comment
Hide comment
@dillaman

dillaman Oct 20, 2017

Contributor

@kmroz What was the cherry-pick conflict in ce62832?

Contributor

dillaman commented Oct 20, 2017

@kmroz What was the cherry-pick conflict in ce62832?

@dillaman

lgtm

@dillaman

This comment has been minimized.

Show comment
Hide comment
@dillaman

dillaman Oct 20, 2017

Contributor

... never mind, I see that it was just about the coverity member variable defaults added to the master branch.

Contributor

dillaman commented Oct 20, 2017

... never mind, I see that it was just about the coverity member variable defaults added to the master branch.

@theanalyst

This comment has been minimized.

Show comment
Hide comment
@theanalyst

theanalyst Oct 27, 2017

Member

Passed a teuthology run at http://tracker.ceph.com/issues/21830#note-7 and will be merged when approved

Member

theanalyst commented Oct 27, 2017

Passed a teuthology run at http://tracker.ceph.com/issues/21830#note-7 and will be merged when approved

@theanalyst theanalyst requested a review from dillaman Oct 27, 2017

@dillaman

👍

@theanalyst theanalyst merged commit 8742c61 into ceph:luminous Oct 27, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment