init-ceph: keep trying other OSDs if we fail to set CRUSH position on one OSD #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 20, 2014 16:28
If we fail to start the daemon, skip the post_start and other steps. Signed-off-by: Sage Weil <sage@inktank.com>
If we fail to set the CRUSH position for one OSD, continue on to try starting others, just as we do when we fail to start the daemon. Fixes: #8342 Signed-off-by: Sage Weil <sage@inktank.com>
|
👍 The $pre_mount and $pre_start commands may also fail and break the loop. If they break the loop because they are bugous, it is probably a good thing. If they would succeed on some OSDs and not others, it's probably a bad thing. Since they are neither documented nor used in upstart scripts there does not seem to be a need to change anything. |
|
Works as expected and fixes the problem. Thanks very much. Please commit. |
ghost
pushed a commit
that referenced
this pull request
May 24, 2014
init-ceph: keep trying other OSDs if we fail to set CRUSH position on one OSD Reviewed-by: Loic Dachary <loic@dachary.org> Reviewed-by: Dmitry Smirnov <onlyjob@debian.org>
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.