Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD: drop unsed parameter passed to check_osdmap_features #18466

Merged
merged 1 commit into from Oct 25, 2017

Conversation

Projects
None yet
5 participants
@zealoussnow
Copy link
Contributor

commented Oct 22, 2017

Signed-off-by: Leo Zhang nguzcf@gmail.com

@zealoussnow

This comment has been minimized.

Copy link
Contributor Author

commented Oct 22, 2017

@liewegas need a review please.

@liewegas

This comment has been minimized.

Copy link
Member

commented Oct 22, 2017

Hmm, if this compiled before, that means the argument isn't used, right? Can we just drop it?

@zealoussnow

This comment has been minimized.

Copy link
Contributor Author

commented Oct 22, 2017

I think we can't drop this parameter, https://github.com/ceph/ceph/blob/master/src/osd/OSD.cc#L7723 use it.

@xiexingguo

This comment has been minimized.

Copy link
Member

commented Oct 24, 2017

I think we can't drop this parameter, https://github.com/ceph/ceph/blob/master/src/osd/OSD.cc#L7723 use it.

That is not true. It is using the internal store member there instead of the parameter passed in.
Can you simply drop that as per Sage suggesting?

OSD: drop unsed parameter passed to check_osdmap_features
Signed-off-by: Leo Zhang <nguzcf@gmail.com>

@zealoussnow zealoussnow force-pushed the zealoussnow:wip-wrong-parameter branch from 5771827 to c3f090c Oct 24, 2017

@zealoussnow

This comment has been minimized.

Copy link
Contributor Author

commented Oct 24, 2017

@xiexingguo OK, I know your means, thank you. I've changed it.

@xiexingguo xiexingguo added the needs-qa label Oct 24, 2017

@zealoussnow zealoussnow changed the title OSD: fix wrong parameter passed to check_osdmap_features OSD: drop unsed parameter passed to check_osdmap_features Oct 24, 2017

@tchaikov

This comment has been minimized.

@tchaikov tchaikov merged commit 1fb6277 into ceph:master Oct 25, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@zealoussnow zealoussnow deleted the zealoussnow:wip-wrong-parameter branch Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.