OSD: drop unsed parameter passed to check_osdmap_features #18466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@liewegas need a review please. |
|
Hmm, if this compiled before, that means the argument isn't used, right? Can we just drop it? |
|
I think we can't drop this parameter, https://github.com/ceph/ceph/blob/master/src/osd/OSD.cc#L7723 use it. |
liu-chunmei
approved these changes
Oct 23, 2017
That is not true. It is using the internal store member there instead of the parameter passed in. |
Signed-off-by: Leo Zhang <nguzcf@gmail.com>
zealoussnow
force-pushed
the
wip-wrong-parameter
branch
from
5771827
to
c3f090c
Compare
|
@xiexingguo OK, I know your means, thank you. I've changed it. |
xiexingguo
approved these changes
Oct 24, 2017
zealoussnow
changed the title
|
the failed tests are due to #18171 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Leo Zhang nguzcf@gmail.com