Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/OpRequest: reduce overhead when disabling tracking #18470

Merged
merged 2 commits into from Oct 24, 2017

Conversation

Projects
None yet
3 participants
@yuyuyu101
Copy link
Member

commented Oct 23, 2017

No description provided.

common/TrackedOp: make tracking_enabled atomic without lock protect
Signed-off-by: Haomai Wang <haomai@xsky.com>

@yuyuyu101 yuyuyu101 force-pushed the yuyuyu101:wip-tracker-lock branch from d6b2d22 to 6edb368 Oct 23, 2017

osd/OpRequest: don't mark_event when disable tracker
Signed-off-by: Haomai Wang <haomai@xsky.com>

@yuyuyu101 yuyuyu101 force-pushed the yuyuyu101:wip-tracker-lock branch from 6edb368 to d105ce6 Oct 23, 2017

@@ -158,10 +158,10 @@ OpTracker::~OpTracker() {

bool OpTracker::dump_historic_ops(Formatter *f, bool by_duration, set<string> filters)
{
RWLock::RLocker l(lock);

This comment has been minimized.

Copy link
@tchaikov

tchaikov Oct 23, 2017

Contributor

this would be nice to have if tracking_enabled were immutable. but we do expose the set_tracking() to the daemons. and they are calling it at run-time without protecting it with any extra locking.

This comment has been minimized.

Copy link
@tchaikov

tchaikov Oct 23, 2017

Contributor

or, we can make tracking_enabled an atomic?

This comment has been minimized.

Copy link
@yuyuyu101

yuyuyu101 Oct 23, 2017

Author Member

already in this pr

@tchaikov tchaikov added the common label Oct 23, 2017

@liewegas liewegas merged commit a91064a into ceph:master Oct 24, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@yuyuyu101 yuyuyu101 deleted the yuyuyu101:wip-tracker-lock branch Oct 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.