osd/OpRequest: reduce overhead when disabling tracking #18470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haomai Wang <haomai@xsky.com>
yuyuyu101
force-pushed
the
wip-tracker-lock
branch
from
d6b2d22
to
6edb368
Compare
Signed-off-by: Haomai Wang <haomai@xsky.com>
yuyuyu101
force-pushed
the
wip-tracker-lock
branch
from
6edb368
to
d105ce6
Compare
tchaikov
reviewed
Oct 23, 2017
| @@ -158,10 +158,10 @@ OpTracker::~OpTracker() { | |||
|
|
|||
| bool OpTracker::dump_historic_ops(Formatter *f, bool by_duration, set<string> filters) | |||
| { | |||
| RWLock::RLocker l(lock); | |||
There was a problem hiding this comment.
this would be nice to have if tracking_enabled were immutable. but we do expose the set_tracking() to the daemons. and they are calling it at run-time without protecting it with any extra locking.
There was a problem hiding this comment.
or, we can make tracking_enabled an atomic?
tchaikov
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.