Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pybind/rados: allow bytearray as data input #18488

Closed
wants to merge 1 commit into from

Conversation

sileht
Copy link
Contributor

@sileht sileht commented Oct 23, 2017

rados python binding currently allow only immutable byte array (bytes).

This change adds support for mutable byte array (bytearray).

Signed-off-by: Mehdi Abaakouk sileht@sileht.net

rados python binding currently allow only immutable byte array (bytes).

This change adds support for mutable byte array (bytearray).

Signed-off-by: Mehdi Abaakouk <sileht@sileht.net>
@tchaikov
Copy link
Contributor

see also #15136

@tchaikov
Copy link
Contributor

This is a very good enhancement when ceph will raise the cython requirement. This avoids ton memory copy.

@sileht i'd suggest track this feature using tracker, and reference it from there instead of keeping this open until we drop the cython 0.19 support.

@sileht
Copy link
Contributor Author

sileht commented Oct 24, 2017

@tchaikov thank for the suggestion, I have created http://tracker.ceph.com/issues/21902

@stale
Copy link

stale bot commented Oct 18, 2018

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you are a maintainer or core committer, please follow-up on this issue to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Oct 18, 2018
@liewegas
Copy link
Member

@tchaikov does this change still make sense?

@stale stale bot removed the stale label Oct 29, 2018
@tchaikov
Copy link
Contributor

@liewegas it makes sense. but in short term, i don't think we can ditch the support of RHEL/CentOS 7, and hence should continue building with cython 0.19, i just checked SCLo, it offers cython 0.25, see http://mirror.centos.org/centos/7/sclo/x86_64/sclo/sclo-python27/ , but there is no aarch64 builds there.

@sileht i am closing this PR at this moment. we will need to reopen it once we are able to use cython 0.20 or up. thanks!

@tchaikov tchaikov closed this Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants