Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/PGMap: 'unclean' does not imply damaged #18493

Merged
merged 1 commit into from Oct 30, 2017

Conversation

Projects
None yet
4 participants
@liewegas
Copy link
Member

commented Oct 23, 2017

Everything (that I can think of) that would lead to a PG being unclean is
already reported via another health message. And there are cases where a
PG is unclean (e.g., because it is backfilling) where we are not degraded.

Fix by ignoring this flag in the health checks.

Signed-off-by: Sage Weil sage@redhat.com

mon/PGMap: 'unclean' does not imply damaged
Everything (that I can think of) that would lead to a PG being unclean is
already reported via another health message.  And there are cases where a
PG is unclean (e.g., because it is backfilling) where we are not degraded.

Fix by ignoring this flag in the health checks.

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas requested review from jcsp and jdurgin Oct 23, 2017

@amitkumar50
Copy link
Contributor

left a comment

LGTM

@tchaikov tchaikov merged commit 12df4aa into ceph:master Oct 30, 2017

4 of 5 checks passed

Docs: build check Docs: failed with errors
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.