osd,mgrclient: pass daemon_status by rvalue ref and other cleanups #18509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
to be consistent with other caller sites of add_event_after(). the original intention of doing so, is to avoid double free of the callback to be added if we are stopping and the timer refuses to add this callback. Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
commented
Oct 24, 2017
| @@ -1318,7 +1318,7 @@ namespace librados | |||
| const std::string& name, ///< daemon name (e.g., 'gwfoo') | |||
| const std::map<std::string,std::string>& metadata); ///< static metadata about daemon | |||
| int service_daemon_update_status( | |||
| const std::map<std::string,std::string>& status); | |||
| std::map<std::string,std::string>&& status); | |||
There was a problem hiding this comment.
the ABI change was discussed at #18468 (comment)
tchaikov
changed the title
jcsp
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a spin-off of #18468. it's posted separately in hope to get reviewed sooner.