build/ops: rpm: recommend python-influxdb with ceph-mgr #18511
Conversation
There was a problem hiding this comment.
To be pedantic, the influxdb module won't run if python-influxdb is not present, but it will at least be graceful about not running. So, that module requires python-influxdb, but mgr itself doesn't. There's probably an argument to be made here for splitting the influxdb module out into a separate optional package (ceph-mgr-module-influxdb or whatever) which itself Requires: python-influxdb. But on the assumption that's a larger discussion about how to maybe package mgr modules, I'm cool with a Recommends:.
I contemplated suggesting (ha!) Suggests:, but judging from https://en.opensuse.org/Libzypp/Dependencies, they're mostly useless, i.e. probably don't actually result in package installation (on SUSE distros, at least).
|
Thanks, @tserong - since the presence of Recommends will cause zypper (at least, maybe not yum?) to try to install the package, this PR hinges on whether a python-influxdb package is available in all the distros/versions we are targeting for Mimic. |
The influxdb module won't run if python-influxdb is not present (but it will be graceful about not running). That means python-influxdb is a dependency of that module, not mgr itself. However, we are not (yet) packaging the modules separately. (When we do, this could become a Requires: of the module.) RPM itself does not support "Recommends", and ignores this line. Higher-level tools may or may not support it, so put this line in a SUSE-only conditional since we know that zypper supports it. Signed-off-by: Nathan Cutler <ncutler@suse.com> Signed-off-by: Tim Serong <tserong@suse.com>
smithfarm
force-pushed
the
wip-rpm-recommend-influxdb
branch
from
3ee5027
to
ca820ff
Compare
|
Changelog:
|
|
|
|
Oh, you're right - since 4.12.0 [1] (I'm running 4.11.0) |
|
(vaguely related: http://tracker.ceph.com/issues/21502) |
The influxdb module won't run if python-influxdb is not present (but it will be
graceful about not running). That means python-influxdb is a dependency of
that module, not mgr itself. However, we are not (yet) packaging the modules
separately. (When we do, this could become a Requires: of the module.)
RPM itself does not support "Recommends", and ignores this line. Higher-level
tools may or may not support it, so put this line in a SUSE-only conditional
since we know that zypper supports it.