ceph-volume: adds the ceph-volume lvm zap subcommand #18513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewschoen
force-pushed
the
ceph-volume-zap
branch
from
0b1f024
to
a3f6d50
Compare
alfredodeza
reviewed
Oct 24, 2017
| ) | ||
|
|
||
| parser.add_argument( | ||
| 'device', |
There was a problem hiding this comment.
I think you can use the validator for LV/device here:
type=arg_validators.LVPath(),
a3f6d50
to
4d6cae2
Compare
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
These should eventually move to a disk api. Signed-off-by: Andrew Schoen <aschoen@redhat.com>
This will remove filesystems and wipe data from any lv or partition given to 'ceph-volume lvm zap' but still leave it intact for further use. Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Will remove all tags for the current lv Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
This correctly sets the tags when a partition is used for a filestore journal. Signed-off-by: Andrew Schoen <aschoen@redhat.com>
andrewschoen
force-pushed
the
ceph-volume-zap
branch
from
4d6cae2
to
1a8561d
Compare
|
jenkins test ceph-volume tox |
alfredodeza
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is used to zap lvs and partitions that had previous be used for lvm OSDs so that they can be reused.