ceph-volume: ensure correct --filestore/--bluestore behavior #18518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
October 24, 2017 15:54
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
…or block and data Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
…ot osd dir paths Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
|
Catching more issues :( Latest problem (hopefully the last one) is that custom cluster names were causing OSDs not to start because they were looking for |
added 2 commits
October 26, 2017 07:48
Signed-off-by: Alfredo Deza <adeza@redhat.com>
Signed-off-by: Alfredo Deza <adeza@redhat.com>
|
This is now good to be merged. I am adding the workarounds for ceph-bluestore-tool because the fixes for that tool aren't in master yet and I prefer to have this working and then consume the fixes later. @andrewschoen if you find anything else in here you want changed, let me know, otherwise this is good to move forward. |
|
jenkins test ceph-volume tox |
andrewschoen
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix makes it so that when
--filestoreis used, it is respected. Before it would always use--bluestorewhich is not correct.Tags were also being polluted when using a journal (in filestore) and db or block in bluestore, keeping the last device set, which would cause the 'data' device being reported as 'db' or 'wal'.
Finally, the
prepareapi was using the old function signature for checking mounts which changed to require the caller to specify if checking for a path or a device.