librbd: don't read metadata twice on image open #18542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillaman
reviewed
Oct 26, 2017
| @@ -274,6 +274,11 @@ struct C_InvalidateCache : public Context { | |||
| trace_endpoint.copy_name(pname); | |||
| perf_start(pname); | |||
|
|
|||
| assert(image_watcher == NULL); | |||
| image_watcher = new ImageWatcher<>(*this); | |||
There was a problem hiding this comment.
Any reason why the ImageWatcher needs to be constructed prior to the refresh state machine? I grepped and didn't immediately see it being referenced (except for the change below to determine if it's safe to apply metadata string overrides).
There was a problem hiding this comment.
In refresh we create exclusive lock, and it (ManagedLock) references the watcher.
dillaman
reviewed
Oct 26, 2017
src/librbd/ImageCtx.cc
Outdated
| image_watcher = new ImageWatcher<>(*this); | ||
| } | ||
|
|
||
| void ImageCtx::post_init() { |
There was a problem hiding this comment.
Nit: perhaps rename to init_cache since it is for the cache and readahead (which technically requires the cache)
After adding get_metadata to RefreshRequest it has become redundant in OpenRequest. Signed-off-by: Mykola Golub <to.my.trociny@gmail.com>
trociny
force-pushed
the
wip-metadata-open
branch
from
56a8365
to
0cb485e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding get_metadata to RefreshRequest it has become redundant
in OpenRequest.
Signed-off-by: Mykola Golub to.my.trociny@gmail.com