osd/osd_types: fix object_stat_sum_t decode #18551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Broken by 71bf047 Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
added
bug-fix
core
wip-sage2-testing
wip-sage-testing
and removed
wip-sage2-testing
wip-sage-testing
labels
|
@liewegas thinking about this I wonder if a static constexpr member function that returns the version number might be easier in terms of maintenance so this is never misinterpreted again? [edit] Hmm... or even this approach? if (struct_v >= MyVersion::value) ... |
tchaikov
approved these changes
Oct 27, 2017
|
I expect the comments will be sufficient, but can switch to a constant if you like. Errors are easily caught by test suite at least! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broken by 71bf047
This fixes the rados/upgrade test