osd/PG: remote recovery preemption, and new feature bit to condition it on #18553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
liewegas
commented
Oct 26, 2017
liewegas
commented
- we did remote backfill preemption; now add recovery too
- new feature bit to guard the new behavior(s) so that this can be backported later
dzafman
approved these changes
Oct 26, 2017
This will allow us to backport support for reservation preemption and cancellations on the wire. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
We did backfill but not recovery. This one is easier because we already have a DeferRecovery event we can queue that does everything. Condition on the RECOVERY_RESERVATION_2 feature. Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-preempt-feature
branch
from
cfc6be8
to
c1e652a
Compare
If we have a REQUEST outstanding and then cancel, send a RELEASE to the REQUEST target too, so that they too can clean up. This avoids leaving the replica in the RepRecovering state when the primary is restarting the whole reservation process. Signed-off-by: Sage Weil <sage@redhat.com>
This was only half-implemented by c1e652a Signed-off-by: Sage Weil <sage@redhat.com>
If we get a REQUEST and RELEASE in quick succession, we may process a local Remote*Reserved back in the RepNotRecovering state. Signed-off-by: Sage Weil <sage@redhat.com>
If we restart the recovery reservation process for some reason (e.g., local preemption), we may still get a racing REVOKE from the replicas in the previous round. Ignore. Signed-off-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.