msg/async: misc cleanup. #18575
Merged
msg/async: misc cleanup. #18575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
Now DelayedDelivery is a timer rather than a thread. So there is no case be called ahead. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
yuyuyu101
reviewed
Oct 28, 2017
| @@ -138,7 +138,6 @@ AsyncConnection::AsyncConnection(CephContext *cct, AsyncMessenger *m, DispatchQu | |||
| write_handler = new C_handle_write(this); | |||
| wakeup_handler = new C_time_wakeup(this); | |||
| tick_handler = new C_tick_wakeup(this); | |||
| memset(msgvec, 0, sizeof(msgvec)); | |||
There was a problem hiding this comment.
I don't like this cleaning, memset call isn't expensive in this path and zeroed memory will be good for other debug purpose
There was a problem hiding this comment.
this parameter don,t use anymore now.
yuyuyu101
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.