osd/PrimaryLogPG: drop unused parameters #18581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joscollin
requested changes
Oct 27, 2017
There was a problem hiding this comment.
See, that function is used here:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/PrimaryLogPG.cc:7026:43: error: no matching function for call to ‘PrimaryLogPG::setattr_maybe_cache(ObjectContextRef&, PrimaryLogPG::OpContext*&, PGTransaction*&, const char [2], ceph::bufferlist&)’
setattr_maybe_cache(obc, ctx, t, OI_ATTR, bv);
wzliao
force-pushed
the
wip-drop-unused-parameter
branch
2 times, most recently
from
35c5176
to
282a41d
Compare
|
@joscollin , thank you for your notice, it has been changed now, please check it out. |
|
@joscollin , i put on the '-Wunused-parameter' option when build the project, got thousands '-Wunused-parameter' warnings, some of them should remain what they are for capability, some of them can be changed, but can not be easily found out, i think we should let they be. |
joscollin
requested changes
Oct 31, 2017
src/osd/PrimaryLogPG.cc
Outdated
| @@ -12536,7 +12536,7 @@ void PrimaryLogPG::hit_set_persist() | |||
| map <string, bufferlist> attrs; | |||
| attrs[OI_ATTR].claim(boi); | |||
| attrs[SS_ATTR].claim(bss); | |||
| setattrs_maybe_cache(ctx->obc, ctx.get(), ctx->op_t.get(), attrs); | |||
| setattrs_maybe_cache(ctx->obc, ctx->op_t.get(), attrs); | |||
There was a problem hiding this comment.
Nit: Fix the unwanted space after ctx->obc,
There was a problem hiding this comment.
@joscollin , fixed it
wzliao
force-pushed
the
wip-drop-unused-parameter
branch
from
282a41d
to
8ed2457
Compare
Signed-off-by: Liao Weizhong <liaoweizhong@unionpay.com>
joscollin
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osd/PrimaryLogPG: drop unused parameters