rbd-mirror: clean up spurious error log messages #18601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillaman
pushed a commit
to dillaman/ceph
that referenced
this pull request
Oct 27, 2017
Previously, if only the local image was using the journal or if a disconnected peer was attached, the tag entries could not be expired even if unreferenced. Fixes: ceph#18601 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
dillaman
pushed a commit
to dillaman/ceph
that referenced
this pull request
Oct 27, 2017
Previously, if only the local image was using the journal or if a disconnected peer was attached, the tag entries could not be expired even if unreferenced. Fixes: ceph#18601 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
amitkumar50
reviewed
Oct 28, 2017
| << "m_client_meta.image_id=" << m_client_meta.image_id << ", " | ||
| << "client.state=" << client.state << dendl; | ||
| dout(5) << "image_id=" << m_local_image_id << ", " | ||
| << "client_meta.image_id=" << m_client_meta.image_id << ", " |
trociny
reviewed
Oct 28, 2017
| } else if (r < 0) { | ||
| derr << "failed to retrieve client: " << cpp_strerror(r) << dendl; | ||
| finish(r); | ||
| } else if (!decode_client_meta()) { | ||
| // require operator intervention since the data is corrupt | ||
| finish(-EBADMSG); | ||
| return; |
There was a problem hiding this comment.
nit: return is not needed (just to be consistent with other clauses, or add it to every clause).
Fixes: http://tracker.ceph.com/issues/21961 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
@trociny update pushed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.