osd/PrimaryLogPG: more oi.extents fixes #18616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
reviewed
Oct 30, 2017
src/osd/PrimaryLogPG.cc
Outdated
| oi.extents.insert(old_size, offset - old_size); | ||
| } | ||
| } | ||
| delta_stats.num_bytes += oi.extents.size(); |
There was a problem hiding this comment.
I would be inclined not to do this patch since it doesn't change the allocations...
There was a problem hiding this comment.
@liewegas Okay, updated.
xiexingguo
force-pushed
the
wip-hunt-scrub-mismatch
branch
2 times, most recently
from
eabdcf7
to
8c630a0
Compare
…operly Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
there's already a builtin operator<< for interval_set, which is simpler. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
There might be holes in the extents map, thus it is not always consistent to calc the clone bytes this way. Instead we could switch to its own (simpler and consistent) way to count used bytes for head-object and clone respectively. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
liewegas
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.