mgr/restful: A couple of restful fixes #18649
Conversation
The CommandsRequest.waiting is an array of arrays, not an array of command results and so it cannot be represented that way. This commit fixes that by outputting the array in json diretly. Signed-off-by: Boris Ranto <branto@redhat.com>
Previously, we forgot to set the value of the argument for the second group of pool variables. Signed-off-by: Boris Ranto <branto@redhat.com>
Signed-off-by: Boris Ranto <branto@redhat.com>
tchaikov
changed the title
|
This PR seems like a good time to add some kind of test coverage for the modifying operations |
|
@b-ranto ping |
Signed-off-by: Boris Ranto <branto@redhat.com>
|
There already are some tests for the modifying operations. However, we did not test pg_num/pgp_num updates. I have added that to the workunit testing the restful module in the latest commit. |
|
I'm a bit concerned that those tests are only going as far as checking the HTTP response from submitting a request: for example the bug behind the "restful: Set the value of the argument" fix would not be caught by this (or would it?). Something like https://github.com/ceph/calamari/blob/master/tests/test_pool_management.py#L196 would be nice. These tests would fit nicely in qa/tasks/mgr where there is more of a framework for tests written in python. I don't want to hold up these patches any longer, but if we're maintaining this module on an ongoing basis then I would like to see more complete tests to come with future PRs. |
|
Is there a backport for Luminous? |
This fixes a couple of bugs in the ceph-mgr restful module.