rgw: fix rewrite a versioning object create a new object bug #18662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
all commits in this PR are signed |
|
submodules for project are unmodified |
|
OK - docs built |
|
@cbodley Please review this PR. Maybe this commit should be backported to luminous. |
|
make check succeeded |
1 similar comment
|
make check succeeded |
|
@cbodley ping~ |
1 similar comment
|
@cbodley ping~ |
|
@ZVampirEM77 can we get a rebase? |
Fixes: http://tracker.ceph.com/issues/21984 Signed-off-by: Enming Zhang <enming.zhang@umcloud.com>
ZVampirEM77
force-pushed
the
wip-em-rewriteobj
branch
from
269b075
to
700a029
Compare
|
@mattbenjamin done~ |
cbodley
approved these changes
Dec 1, 2017
|
manually tested the rewrite and confirmed that it didn't create a new version 👍 |
2 similar comments
mattbenjamin
pushed a commit
to linuxbox2/ceph
that referenced
this pull request
Jan 3, 2018
A name is almost an oid. Except that if a name starts with a _, the corresponding oid starts with a double _. The copy logic passes the oid straight in as a name, which results in a triple _ on the oid, resulting in an object name with a double __. Fix: remove one _ when converting an oid back into a name, so that the final oid only has a double _. Fixes: http://tracker.ceph.com/issues/22529 This change is not needed on master or Luminous, due to already-merged ceph#18662. Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
ivancich
pushed a commit
to ivancich/ceph-fork
that referenced
this pull request
Mar 27, 2018
A name is almost an oid. Except that if a name starts with a _, the corresponding oid starts with a double _. The copy logic passes the oid straight in as a name, which results in a triple _ on the oid, resulting in an object name with a double __. Fix: remove one _ when converting an oid back into a name, so that the final oid only has a double _. Fixes: http://tracker.ceph.com/issues/22529 Resolves: rhbz#1515275 This change is not needed on master or Luminous, due to already-merged ceph#18662. Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
guihecheng
pushed a commit
to guihecheng/ceph
that referenced
this pull request
Sep 12, 2018
A name is almost an oid. Except that if a name starts with a _, the corresponding oid starts with a double _. The copy logic passes the oid straight in as a name, which results in a triple _ on the oid, resulting in an object name with a double __. Fix: remove one _ when converting an oid back into a name, so that the final oid only has a double _. Fixes: http://tracker.ceph.com/issues/22529 Resolves: rhbz#1515275 This change is not needed on master or Luminous, due to already-merged ceph#18662. Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/21984
$ rados -p default.rgw.buckets.data lscad03102-431e-4820-942e-efab29247df8.4120.1__shadow:cmhtSYIYdexIZfwSvZQdRQZSVF4i8q7_.74jv0KaZ03PqoWU5st8pEESl9VWCdC6_1
cad03102-431e-4820-942e-efab29247df8.4120.1_ver-10M
cad03102-431e-4820-942e-efab29247df8.4120.1__:cmhtSYIYdexIZfwSvZQdRQZSVF4i8q7_ver-10M
cad03102-431e-4820-942e-efab29247df8.4120.1__shadow:cmhtSYIYdexIZfwSvZQdRQZSVF4i8q7_.74jv0KaZ03PqoWU5st8pEESl9VWCdC6_2
$ radosgw-admin object rewrite --bucket=111 --object=ver-10M --object-version=cmhtSYIYdexIZfwSvZQdRQZSVF4i8q7$ rados -p default.rgw.buckets.data lscad03102-431e-4820-942e-efab29247df8.4120.1__shadow:cmhtSYIYdexIZfwSvZQdRQZSVF4i8q7_.74jv0KaZ03PqoWU5st8pEESl9VWCdC6_1
cad03102-431e-4820-942e-efab29247df8.4120.1_ver-10M
cad03102-431e-4820-942e-efab29247df8.4120.1__:cmhtSYIYdexIZfwSvZQdRQZSVF4i8q7_ver-10M
cad03102-431e-4820-942e-efab29247df8.4120.1__shadow:cmhtSYIYdexIZfwSvZQdRQZSVF4i8q7_.osEcr1uHdcP8V6AzRJhzItAtnAUkrCT_2
cad03102-431e-4820-942e-efab29247df8.4120.1__shadow:cmhtSYIYdexIZfwSvZQdRQZSVF4i8q7_.74jv0KaZ03PqoWU5st8pEESl9VWCdC6_2
cad03102-431e-4820-942e-efab29247df8.4120.1__shadow:cmhtSYIYdexIZfwSvZQdRQZSVF4i8q7_.osEcr1uHdcP8V6AzRJhzItAtnAUkrCT_1
$ s3cmd ls s3://1112017-11-01 07:05 10485760 s3://111/ver-10M
$ radosgw-admin gc list --include-all[
{
"tag": "cad03102-431e-4820-942e-efab29247df8.4120.5\u0000",
"time": "2017-11-01 17:07:37.0.587706s",
"objs": [
{
"pool": "default.rgw.buckets.data",
"oid": "cad03102-431e-4820-942e-efab29247df8.4120.1__shadow:cmhtSYIYdexIZfwSvZQdRQZSVF4i8q7_.74jv0KaZ03PqoWU5st8pEESl9VWCdC6_1",
"key": "",
"instance": ""
},
{
"pool": "default.rgw.buckets.data",
"oid": "cad03102-431e-4820-942e-efab29247df8.4120.1__shadow:cmhtSYIYdexIZfwSvZQdRQZSVF4i8q7_.74jv0KaZ03PqoWU5st8pEESl9VWCdC6_2",
"key": "",
"instance": ""
}
]
}
]