rgw: init oldest period after setting run_sync_thread #18664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
all commits in this PR are signed |
|
submodules for project are unmodified |
|
OK - docs built |
|
make check succeeded |
1 similar comment
|
make check succeeded |
cbodley
reviewed
Nov 1, 2017
src/rgw/rgw_rados.cc
Outdated
| // running under radosgw-admin, so we check run_sync_thread here before | ||
| // disabling it based on the zone/zonegroup setup | ||
| meta_mgr->init_oldest_log_period(); | ||
| } |
There was a problem hiding this comment.
moving this down is fine, but the comment still talks about checking run_sync_thread here before disabling it based on the zone/zonegroup setup, which happens in the block above - could you please update or remove the comment?
|
@oritwas i found the crash bug in diff --git a/src/rgw/rgw_period_history.cc b/src/rgw/rgw_period_history.cc
index 895700f..1f0dbee 100644
--- a/src/rgw/rgw_period_history.cc
+++ b/src/rgw/rgw_period_history.cc
@@ -137,6 +137,8 @@ RGWPeriodHistory::Impl::Impl(CephContext* cct, Puller* puller,
// get a cursor to the current period
current_cursor = make_cursor(current_history, current_period.get_realm_epoch());
+ } else {
+ current_history = histories.end();
}
} |
|
found it too :) , will include it |
Fixes: http://tracker.ceph.com/issues/21996 Signed-off-by: Orit Wasserman <owasserm@redhat.com>
Fixes: http://tracker.ceph.com/issues/21996 Signed-off-by: Orit Wasserman <owasserm@redhat.com> Signed-off-by: Casey Bodley <cbodley@redhat.com>
oritwas
force-pushed
the
wip-rgw-21996
branch
from
4bdf5ec
to
cc3246c
Compare
cbodley
approved these changes
Nov 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/21996
Signed-off-by: Orit Wasserman owasserm@redhat.com