erasure-code: refactor the interfaces to hide internals from public #18683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
changed the title
|
@mynaramana does this make sense? |
tchaikov
force-pushed
the
wip-erasure-cleanup
branch
5 times, most recently
from
5db6307
to
37b6c5b
Compare
|
jenkins test this please |
tchaikov
force-pushed
the
wip-erasure-cleanup
branch
from
37b6c5b
to
246628e
Compare
after the arraycode change, the old encode() and minimum_to_decode() are actually replaced by the new counterparts, and are only used by the ErasureCode itself. so they can be marked `private`, but the unittests are still using them heavily. so they are kept `public`. and to avoid the `-Woverloaded-virtual` warnings, because the new methods share the same names with the old ones. a underscore is used as the prefix of the internal methods. Signed-off-by: Kefu Chai <kchai@redhat.com>
…r ErasureCodeExample so instead of implementing it, we can just use it default one. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-erasure-cleanup
branch
from
246628e
to
203ddce
Compare
Closed
liewegas
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after the arraycode change, the old encode() and minimum_to_decode() are
actually replaced by the new counterparts, and are only used by the
ErasureCode itself. so they can be marked
private, and to avoid the-Woverloaded-virtualwarnings, because the new methods share the samenames with the old ones. an underscore is used as the prefix of the
internal methods.
Signed-off-by: Kefu Chai kchai@redhat.com