mgr/DaemonServer.cc: [Cleanup] Change to using get_val template function #18717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>
|
@shinobu-x The most valuable way to approach this would be to make the goal removing items from legacy_config_opts.h. As soon as all users of the variable have switched to get_val<> then we can remove the definition from that file. |
|
@liewegas Thanks for your suggestion. I will do more staff for the goal. |
|
These lines will ultimately change anyway when the settings are cleaned up from legacy_config_opts.h, so I don't mind merging this ahead of that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shinobu Kinjo shinobu@redhat.com