os/bluestore: optimize _collection_list. #18777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
reviewed
Nov 16, 2017
src/os/bluestore/BlueStore.cc
Outdated
| @@ -7213,8 +7213,7 @@ int BlueStore::_collection_list( | |||
| if (!pnext) | |||
| pnext = &static_next; | |||
|
|
|||
| if (start == ghobject_t::get_max() || | |||
| start.hobj.is_max()) { | |||
| if (start.is_max()) { | |||
There was a problem hiding this comment.
this is important because we want to skip out even if ghobject_t::max is false but hobj.max is true.
liewegas
changed the title
majianpeng
force-pushed
the
bluestore-collection-list
branch
from
883f143
to
ede0d94
Compare
|
update. BTW Whan't mean if ghobject_t::is_max is false but hobj.is_max is true? Thanks! |
|
See 3fa09f0. If I remember correctly it was either this, or adding a special case in the caller so that if we have hobject_t max and are composing the ghobject_t we conditoinally do {shard,hobj} or max depending on whether hobj.is_max(). This was simpler (since <shard,max> is still clearly the end of the collection). |
liewegas
approved these changes
Nov 17, 2017
|
Thanks! |
|
Thanks very much sage! |
…stent_count. If next != ghobject_t::get_max(), this mean collection has more data than nonexistent_count. For this we should bypass check. And fix wrong comments because _collection_list don't return object num. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
If next is null, we already set a non-null to it. So don't check again. Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.