mon: NULL check of logger before use #18788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins retest this please |
1 similar comment
|
jenkins retest this please |
liewegas
approved these changes
Nov 16, 2017
liewegas
reviewed
Nov 16, 2017
src/mon/Monitor.cc
Outdated
| @@ -3831,6 +3831,7 @@ void Monitor::remove_all_sessions() | |||
| Mutex::Locker l(session_map_lock); | |||
| while (!session_map.sessions.empty()) { | |||
| MonSession *s = session_map.sessions.front(); | |||
| assert(logger); | |||
| remove_session(s); | |||
| if (logger) | |||
There was a problem hiding this comment.
in that case youc an remove the if (logger) here?
amitkumar50
force-pushed
the
cov-mon-1
branch
from
38706c5
to
150288e
Compare
Fixes the coverity issue: CID 1316234 (ceph#1 of 1): Dereference after null check (FORWARD_NULL) 6. var_deref_model: remove_session dereferences null this->logger Signed-off-by: Amit Kumar <amitkuma@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the coverity issue:
Signed-off-by: Amit Kumar amitkuma@redhat.com